No-fork bug in subshell.c

[krader1961]

This statement

ast/src/cmd/ksh93/sh/subshell.c

Line 582 in e756d5b

if (!(sp->nofork = sh_state(SH_NOFORK))) sh_onstate(shp, SH_NOFORK);

is broken as the condition can never be true since sh_state(SH_NOFORK) always returns a non-zero value. Thus the sh_onstate(shp, SH_NOFORK) will never be executed. So the question is what was intended? This is one of only two places where sh_onstate(shp, SH_NOFORK) appears (the other is in xec.c).

P.S., This same bug exists in the ksh93u+ release.

[krader1961]

See also issue #480 and many related issues.