BTree(Key|Value)Iterator cannot be constructed out of module
fay59 opened this issue · 4 comments
While the BTree class is exposed to allow mere mortals to create collections based on it, the BTreeKeyIterator
and BTreeValueIterator
types have internal accessors and cannot be constructed from outside the BTree
module. That feels somewhat inconsistent.
I felt these two types were too simple to be worth extending much effort on designing their public API; they're pretty much implementation details for List
and OrderedSet
. I wouldn't oppose documenting their initializers and making them public, though — PR, please :)
Sure. Which branch would you prefer the PR to target?
Le 18 juin 2016 à 00:54:49, Károly Lőrentey notifications@github.com a écrit :
I felt these two types were too simple to be worth extending much effort on designing their public API; they're pretty much implementation details for List and OrderedSet. I wouldn't oppose documenting their initializers and making them public, though — PR, please :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #14 (comment), or mute the thread https://github.com/notifications/unsubscribe/ACtJ5MfmC78eXRIRUjdqoZMFY08xXcQjks5qM6RJgaJpZM4I43N4.
I think it should go into swift3
for now.
Károly
On 18 Jun 2016, at 20:53, Félix Cloutier notifications@github.com wrote:
Sure. Which branch would you prefer the PR to target?
Le 18 juin 2016 à 00:54:49, Károly Lőrentey notifications@github.com a écrit :
I felt these two types were too simple to be worth extending much effort on designing their public API; they're pretty much implementation details for List and OrderedSet. I wouldn't oppose documenting their initializers and making them public, though — PR, please :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #14 (comment), or mute the thread https://github.com/notifications/unsubscribe/ACtJ5MfmC78eXRIRUjdqoZMFY08xXcQjks5qM6RJgaJpZM4I43N4.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
BTree 4.0.0 includes a sorted multiset collection; this eliminates the primary usecase for making BTreeKeyIterator
's initializer public. (Please reopen this issue if you still need it.)