Support passing a custom *http.Client
Closed this issue · 3 comments
jybp commented
AFAICT there is no way to currently pass a custom *http.Client
to the lib. Meaning consumers have no way to configure it nor can they use custom http.RoundTripper
s. It's usually a good practice to have that possibility.
It's usually passed in a specific constructor or within a functional option.
func WithHttpClient(client *http.Client) Parameter
could be added in parameters.go
I could work toward a PR if maintainers have no bandwidth.
mcdee commented
Please could you take a look at #170 and see if this meets your requirement? Thanks.
jybp commented
Yes this looks great. Thanks Jim.