attilabuti/vscode-mjml

Supporting component preview/rendering in this extension

cbrevik opened this issue · 4 comments

cbrevik commented

I'm trying to develop some components to use with MJML.

I've tried cloning the following example project: https://github.com/mjmlio/mjml-component-boilerplate

When following the instructions, the custom component will not render in the extension preview, nor is it rendered with the HTML which is generated with this extension.

It is rendered in the HTML generated by the Gulp-script in that project though.

Does this extension inspect the .mjmlconfig which defines the component? Or is it some other issue?

From VSCode:
image

attilabuti commented

Thank you for your contribution!
The issue is fixed on 0.0.7.

  • 👍1
JRileyH commented

This appears to be broken again...
From vsCode:
screen shot 2018-03-26 at 7 24 29 pm

jskrzypek commented

I think the reason it's broken again is that the .mjmlconfig is not yet working in mjml@^4.0.0 It looks like this PR might be intended to fix that: mjmlio/mjml#1131

jskrzypek commented

I'll make a new PR to update to the new mjmlconfig functionality that will be released in 4.1.0 (I believe) additional PR to track is here: mjmlio/mjml#1206

  • 👍1