atuline/WLED

Peek colors are incorrect

T00LF00L opened this issue · 8 comments

What happened?

Installed latest sound reactive version from the web installer and the colors shown when the peek tab is active are incorrect.

To Reproduce Bug

Activate peek tab

Expected Behavior

Colors should match LEDs.

Install Method

From web installer

What version of Soundreactive WLED?

0.13.3

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Can you give us some more details?

  • what does "incorrect" mean for you? Too dim, too bright, red instead of green?
  • what kind of LED stripe do you use
  • what color order did you choose in LED settings (RGB, BGR, ...) ?

Right here you can see I make the lights blue, peek shows them green. Everything was setup correctly, BGR with 2812 LEDs, I updated to latest release and not only is peek wrong, but many effects will not use random color cycle anymore, they’re all stuck on pink/blue shades only.
5049D14D-0BFC-4278-8FA6-FE847529F28A

Here is fire effect, LEDs are correct fire color, peek is purple/blue.
2D0BDC29-4096-4E22-841D-FCDD849E00C7

So for example, when I use the DJ Lights effect with the mic, I’m only getting pink & white colors and some blue, nothing else. Or some other effects, if I select random color cycle, I can see the colors cycling in the menu, but the LEDs stay on either shades of pink, or a green/yellow mix. The color pallets seem to be broken and they don’t match what peek is showing either.

I have a similar issue after updating to version 0.13.3. If I choose RGB color order, the LED color follows the color wheel. If I choose GBR order, LED color matches Peek.
GBR

Fixed in ecb0d48

Issue was not Rgb/grb but peek1D not using the right led values.

@wojteksolo , @T00LF00L , can you let me know if it works now then I can close the issue

Yes sir, I confirmed this is fixed.
Sorry I was so vague, this is extremely new to me. The last time I looked at code it was on a Commodore 64..

No worries, didn't seem vague to me ;-)
Code hasn't changed much since then ;-)

Closing the issue now