I2S not working
coolinger opened this issue · 5 comments
What happened?
With commit f07b2ae, I2S is not working anymore.
To Reproduce Bug
Checkout f07b2ae and compile
Expected Behavior
I2S working like before
Install Method
Self-Compiled or other
What version of Soundreactive WLED?
SR WLED Build 2211201
Which microcontroller/board are you seeing the problem on?
ESP32
Relevant log/trace output
AS: Generic I2S Microphone - left channel only.
AS: Failed to initialize sound input driver. Please check input PIN settings.Anything else?
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Hi, thanks for the fast feedback :-)
I've quickly tested it before making that commit, maybe the new sanity checks are still too strict.
Can you please
- add a screenshot of your sound setting?
- recompile with
-D SR_DEBUG -D NO_MIC_LOGGERadded to yourbuild_flags? This will enable a few more debug messages that should help me to find out why the driver refuses to initialize.
Update: found it. Missing brackets around one of the new checks. Will commit a fix later today.
Thanks again for reporting this!
Thanks for quick reply. I really tried to find the bug myself but gave up eventually. After you wrote "missing brackets" i found it too (line 176?). But my git{,hub}-fu is too low to be of any further help ;)
Keep up the great work!
Yes, line 179, so the return statement was always executed even when no error happened - misleading indentation.
Please check out commit f889836 and tell me if it works for you again.
Works again, thanks!