Charging complete time keeps updating after charge is complete

[wigster]

Thanks for implementing the charge complete datetime sensor. #318

There is one behaviour that doesn't seem optimal -- the sensor keeps updating to the last_update time from the vehicle even after the charging is done.

I would suggest a small modification: that the charging_complete_time sensor be updated as long as the _charging_state sensor has the state charging. Once it goes to readyForCharging or even notReadyForCharging, the _charging_complete_time sensor should stop updating, keeping its last value.

I think this would be accurate enough, given that the car talks to the cloud often while charging and would keep the approximate last date of last charge in the sensor until the next charge.

[coreywillwhat]

This would be a bit more complex, but I agree it would be ideal. I can work on it when I have time. Unfortunately, my time to work on this will be dwindling with a baby coming in less than 2 weeks.

In the meantime this could be achieved within HA using helpers/automations/trigger template sensors, but those methods would also essentially render the charging_complete_time useless as you would have replaced it nearly entirely haha

Like I said, i'll try to work it out when I have the time though.
Always appreciate the feedback and suggestions to make this integration better!

[coreywillwhat]

FYI - This is all set, and working on my end. PR #376 submitted just needs review/merge.