audiocogs/aurora.js

Doesn't compile on Visual Studio 2015 Update 3 : '__pfnDliNotifyHook2': redefinition; different type modifiers

Closed this issue · 2 comments

Copy paste from MS's delayimp.h header

// Prior to Visual Studio 2015 Update 3, these hooks were non-const.  They were
// made const to improve security (global, writable function pointers are bad).
// If for backwards compatibility you require the hooks to be writable, define
// the macro DELAYIMP_INSECURE_WRITABLE_HOOKS prior to including this header and
// provide your own non-const definition of the hooks.

This result in the following error :

win_delay_load_hook.c(35): error C2373: '__pfnDliNotifyHook2': redefinition; different type modifiers

Solution, just add the define DELAYIMP_INSECURE_WRITABLE_HOOKS in win_delay_load_hook.c

#define DELAYIMP_INSECURE_WRITABLE_HOOKS
#define WIN32_LEAN_AND_MEAN
#include <windows.h>

#include <delayimp.h>
#include <string.h>

Hmm, not sure where this is coming from, definitely not in aurora. No native code to compile here. Maybe node-speaker?

After verification you are right, it's the subdependecy node-speaker that doesn't compile i didn't check properly.

I don't need an audio backend (just decoding), is there a way to use https://github.com/audiocogs/mp3.js without av ?