audiojs/audio-loader

npm access

dy opened this issue · 3 comments

dy commented

Hi @danigb!

I've been doing bits of refactoring here lately, mostly to freshen up the project and make node paths support, because absolute paths were not supported. Also I updated some dep packages, like audio-decode.

I've made a PR and it seemed to be fine, so I released the version 1.0. Not paying much attention I merged to master, merging the PR that way (my bad, but eventually that would happen :).
Can you please check the commits and if everything is fine - publish the npm module?

I'd also ask you for npm access to publish package later myself if you don't mind.
Appreciate!

dy commented 
npm owner add dfcreative audio-loader
npm owner add jamen audio-loader
danigb commented

Hi @dfcreative and @jamen

I took some time thinking about giving a little love to this repository, but I can not find the time. In fact, I've been thinking in simplifying the code and split it into more composable abstractions. I hope I can show you what I would like to do shortly.

Meanwhile thanks for the updates, the dependencies reduction is great. I've just given you access to the npm repo. 👍

saludos,
Dani

  • 👍3
dy commented

Done. Thank you @danigb!
Yes, there are possible API improvements for this module.
I'd suggest simplifying multiple sources loading to

load([url1, url2, url3, url4], (err, [buf1, buf2, buf3, buf3]) => {})
//or
load(list).then(allOk, anyFailed, progress)
  • 👍1