auralia/node-nsapi

BUG: Nation names ending with underscores edge-case

Opened this issue · 0 comments

The current API implementation will use toId() to convert nation names before submitting a request.
The implementation of toId is however slightly flawed: for a nation Foo_ it will return foo instead of the expected foo_.

This is an edge case, as there is currently only two nations in the world ending with an underscore (and none starting with one).

The obvious fix is to trim only whitespace, not underscores as well.