Update Contributing section in README.md

Question

Update Contributing section in README.md

Closed this issue 11 years ago · 7 comments

The Contributing section points to The Book on Aura GitHub repository, which points back to this repository in its contributing section. If this is now the master copy of the manual, could the README.md file be updated?

Answer 1 · 2013-09-30T10:31:26.000Z

@adduc I didn't get exactly where the issue is. Is it on ReadMe of the book-on-aura ?

I am happy to merge if you can send a Patch.

Thanks

Answer 2 · 2013-09-30T13:38:42.000Z

I apologize for not being clear. I'm suggesting that the Contributing section in this repository's README.md file is a little unclear, and may be out of date. It seems to indicate that development on the manual is still being done primarily in the Book of Aura repository, and does not lay out the guidelines behind contributing to this repository in particular.

Pull request #19 replaces the previous Contributing section with language indicating pull requests are allowed, and encouraged.

Answer 3 · 2013-09-30T13:51:04.000Z

Thanks @adduc -- this looks reasonable to me. @harikt what do you think?

Answer 4 · 2013-09-30T14:31:53.000Z

Yes @pmjones , I didn't checked the README.md in the auraphp.github.com . I was looking at my repo README.md .

As the PR is there I am mergring @pmjones 👍 .

Thank you @adduc .

Answer 5 · 2013-09-30T14:41:52.000Z

@pmjones I merged, and later I thought of having the same wordings taken from http://auraphp.com/manuals/v1/en/

Answer 6 · 2014-01-29T17:33:39.000Z

Is this still an active issue? If not, I can close it.

Answer 7 · 2014-01-30T01:09:22.000Z

closing. The PR was merged, and made the corrections.