Matching Return Type of HybridRouteLayer and RouteLayer
Opened this issue · 0 comments
Kim-Eungseo commented
Matching Return Type of HybridRouteLayer and RouteLayer
Feature Request
Description
I think matching the return type of HybridRouteLayer
and RouteLayer
is a good idea. This would ensure consistency across different route layers and simplify the integration process.
Rationale
- Consistency: Having consistent return types across different route layers will make the codebase easier to understand and maintain.
- Ease of Use: Developers will find it easier to work with both layers if they have the same return type, reducing the learning curve and potential for errors.
- Integration: Simplifies the process of integrating different route layers within the same application, leading to a more seamless development experience.
Possible Implementation
# Example of aligning return types (pseudocode)
class HybridRouteLayer:
...
def __call__(self, query: Optional[str] = None) -> RouteChoice:
# Implementation
class RouteLayer:
...
def __call__(self, query: Optional[str] = None) -> RouteChoice:
# Implementation