Questions
LeaVerou opened this issue · 2 comments
LeaVerou commented
Hi, I have some questions/remarks about your code:
- Is there a particular reason you're creating a script element and not something else?
- Is there a particular reason you're appending to documentElement and not to body?
- I think setting it to none and checking for that would be better, in the hypothetical case a browser has it present but read-only. auto is the default value.
- Why getPropertyValue('pointer-events') instead of just .pointerEvents? Are there any browser support issues of the latter?
- If getComputedStyle isn't present, undefined will be returned instead of false.
ausi commented
- i am using the script element because it is allowed in the head and also in the body, so i thougt no browser should have a problem appending this element to the documentElement. But i didn't test other elements.
- document.body does not exist if the script is included in the header
- that sounds good, i will change this
- i don't think there are any browser support issues, i will change this
- i will change the return statement to "return !!supports"
ausi commented
- now the element
x
is used - ...
- opera accepts the value
none
. So i had to useauto
. - done
- done