Pass a block to Sensor#when_received_data
Closed this issue · 3 comments
pcasaretto commented
Hey,
I wanted to enable passing a block to Sensor#when_received_data and I was worried about mantaining backwards compatibility, but then I came across this commit ee67d3f .
Should I care about backwards compatibility here?
I actually have both versions ready.
austinbv commented
The gem is new and < v1.0 so backwards compatibly is not huge to me.
pcasaretto commented
Cool. So design-wise, would you like for the method to handle both procs and blocks?
Personally, I would go with just blocks.
austinbv commented
just blocks is fine. I don't know why I did procs to begin with...
If you wanna go ahead and add it go ahead and knock yourself out otherwise I will do it when I get a few minutes.