auth0/angular2-jwt

Please respect semver

Masterxilo opened this issue · 3 comments

npm update just upgraded this library from ^5.0.1 to ^5.1.0, but this breaks compatibility with Angular 10, because, as you state

"This project only supports the actively supported versions of Angular as stated in the Angular documentation. Whilst other versions might be compatible they are not actively supported"
and v10 is no longer supported.

However, this is a breaking change, so

this new version that you released after 2 years (!) should have been called 6.0.0

Please respect next time.

A minor version upgrade is supposed to include new features but no breaking changes.

The build errors I got looked like this


[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] ERROR in node_modules/@auth0/angular-jwt/lib/jwthelper.service.d.ts:13:21 - error TS2694: Namespace '"/data/jenkins/workspace/aubsgesuch-ui_feature_npm-update/node_modules/@angular/core/core"' has no exported member 'ɵɵFactoryDeclaration'.

[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] 13     static ɵfac: i0.ɵɵFactoryDeclaration<JwtHelperService, never>;

[2022-10-06T09:13:35.948Z]                        ~~~~~~~~~~~~~~~~~~~~

[2022-10-06T09:13:35.948Z] node_modules/@auth0/angular-jwt/lib/jwthelper.service.d.ts:14:22 - error TS2694: Namespace '"/data/jenkins/workspace/aubsgesuch-ui_feature_npm-update/node_modules/@angular/core/core"' has no exported member 'ɵɵInjectableDeclaration'.

[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] 14     static ɵprov: i0.ɵɵInjectableDeclaration<JwtHelperService>;

[2022-10-06T09:13:35.948Z]                         ~~~~~~~~~~~~~~~~~~~~~~~

[2022-10-06T09:13:35.948Z] node_modules/@auth0/angular-jwt/lib/jwt.interceptor.d.ts:21:21 - error TS2694: Namespace '"/data/jenkins/workspace/aubsgesuch-ui_feature_npm-update/node_modules/@angular/core/core"' has no exported member 'ɵɵFactoryDeclaration'.

[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] 21     static ɵfac: i0.ɵɵFactoryDeclaration<JwtInterceptor, never>;

[2022-10-06T09:13:35.948Z]                        ~~~~~~~~~~~~~~~~~~~~

[2022-10-06T09:13:35.948Z] node_modules/@auth0/angular-jwt/lib/jwt.interceptor.d.ts:22:22 - error TS2694: Namespace '"/data/jenkins/workspace/aubsgesuch-ui_feature_npm-update/node_modules/@angular/core/core"' has no exported member 'ɵɵInjectableDeclaration'.

[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] 22     static ɵprov: i0.ɵɵInjectableDeclaration<JwtInterceptor>;

[2022-10-06T09:13:35.948Z]                         ~~~~~~~~~~~~~~~~~~~~~~~

[2022-10-06T09:13:35.948Z] node_modules/@auth0/angular-jwt/lib/angular-jwt.module.d.ts:20:21 - error TS2694: Namespace '"/data/jenkins/workspace/aubsgesuch-ui_feature_npm-update/node_modules/@angular/core/core"' has no exported member 'ɵɵFactoryDeclaration'.

[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] 20     static ɵfac: i0.ɵɵFactoryDeclaration<JwtModule, [{ optional: true; skipSelf: true; }]>;

[2022-10-06T09:13:35.948Z]                        ~~~~~~~~~~~~~~~~~~~~

[2022-10-06T09:13:35.948Z] node_modules/@auth0/angular-jwt/lib/angular-jwt.module.d.ts:21:21 - error TS2694: Namespace '"/data/jenkins/workspace/aubsgesuch-ui_feature_npm-update/node_modules/@angular/core/core"' has no exported member 'ɵɵNgModuleDeclaration'.

[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] 21     static ɵmod: i0.ɵɵNgModuleDeclaration<JwtModule, never, never, never>;

[2022-10-06T09:13:35.948Z]                        ~~~~~~~~~~~~~~~~~~~~~

[2022-10-06T09:13:35.948Z] node_modules/@auth0/angular-jwt/lib/angular-jwt.module.d.ts:22:21 - error TS2694: Namespace '"/data/jenkins/workspace/aubsgesuch-ui_feature_npm-update/node_modules/@angular/core/core"' has no exported member 'ɵɵInjectorDeclaration'.

[2022-10-06T09:13:35.948Z] 

[2022-10-06T09:13:35.948Z] 22     static ɵinj: i0.ɵɵInjectorDeclaration<JwtModule>;

[2022-10-06T09:13:35.948Z]   

Hey, thanks for reaching out.

I tried elaborating on the decision here, I also understand it can break a couple of people. But important to point out that if this release breaks you, you are using an unsupported version of Angular.

We can't realy provide support for software that isn't supported by itself. I know this can be considered a breaking change from your point of view, and sorry about that. But when you consider any version of Angular that is supported, the change is non-breaking.

You can still pin your versions to ~5.0.1 untill you managed to update to a version of Angular that does receive security fixes, being Angular 12 or higher.