The branding location changes is a breaking change
Closed this issue · 5 comments
Checklist
- I have looked into the README and have not found a suitable solution or answer.
- I have looked into the documentation and have not found a suitable solution or answer.
- I have searched the issues and have not found a suitable solution or answer.
- I have upgraded to the latest version of this tool and the issue still persists.
- I have searched the Auth0 Community forums and have not found a suitable solution or answer.
- I agree to the terms within the Auth0 Code of Conduct.
Description
The recent changes to the branding template path have caused a bug in the deploy pipeline: 4b24d78:
2024-08-09T11:42:34.633Z - error: Problem running command import
2024-08-09T11:42:34.634Z - error: Problem deploying branding, Error: Unable to load file /actions-runner/_work/config-customer-authentication/config-customer-authentication/branding_templates/universal_login.html due to Error: ENOENT: no such file or directory, access '/actions-runner/_work/config-customer-authentication/config-customer-authentication/branding_templates/universal_login.html'
Expectation
The deploy to work as expected
Reproduction
Just run the deploy to auth0 using the CLI
Deploy CLI version
7.24.1
Node version
20.x
I would like to say this is not a bug but more of a breaking change. In this PR the code that loads the branding template completely ignores the templateDefinition.body and instead expects a file named ${templateDefinition.template}.html.
I'm currently using liquid templates and this pretty much breaks the use for them.
Created this PR: #942
I would like to say this is not a bug but more of a breaking change.
I've updated the issue name to reflect it, you're right
We've just come across this. Worth reverting the original change and getting a new version out?
A fix for this has been provided in 7.24.2. Please update and advise if you have any further issue.
I would appreciate you test this out and if problem still persists, we can re-evaluate. However I'm going to close in the meantime. Thanks for opening this ticket!