Function to enable WebAuthN Platform factor updates wrong factor
brianhyder opened this issue · 2 comments
brianhyder commented
While looking at the new Terraform module, I saw that webauthn support did not appear in the Guardian resource. I dug in to the source code for the Go SDK and looked at the implementation for enabling webauthn. The function appears to pass in webauthn-roaming
as the factor type when it should be passing webauthn-platform
.
Looking at the unit test, it appears that it only verifies the enabled
property and not the factor type that was also provided.
sergiught commented
Hey @brianhyder! Thanks a lot for spotting this, we'll fix this soon! Much appreciated.
sergiught commented
This was now fixed and the tests improved. Thanks again @brianhyder! 🙏🏻
We'll include this in the next release.