auth0/node-samlp

xmldom dependency issue

pmolestina opened this issue · 4 comments

Hello,
We have an issue trying to deploy our application that uses this library because the xmldom dependency is pointing to another github repository.
Our deployment servers don't have internet access, we use Nexus internally to host any dependencies.
This is the depedency I'm referring to:
"xmldom": "auth0/xmldom#v0.1.19-auth0_1"

Can this be modified to it refers to a specific version in NPM?

Hi,
I'm encountering this same issue, we do not have git installed and we would not like to install it.
We are currently using oraclelinux Docker container and it does not contain git by default and we like to keep it that way.

You can easily test this by:

docker pull oraclelinux
docker run -it --entrypoint /bin/bash oraclelinux

yum install -y npm

npm init
# do init stuff to get package.json file
npm i --save samlp

Installation stops in error:

npm ERR! git clone --template=/root/.npm/_git-remotes/_templates --mirror git@github.com:auth0/xmldom.git /root/.npm/_git-remotes/git-github-com-auth0-xmldom-git-v0-1-19-auth0-1-cc06230f: undefined
npm ERR! git clone --template=/root/.npm/_git-remotes/_templates --mirror git@github.com:auth0/xmldom.git /root/.npm/_git-remotes/git-github-com-auth0-xmldom-git-v0-1-19-auth0-1-cc06230f: undefined
npm ERR! Linux 4.9.125-linuxkit
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "i" "samlp"
npm ERR! node v6.17.1
npm ERR! npm  v3.10.10
npm ERR! code ENOGIT

npm ERR! not found: git
npm ERR! 
npm ERR! Failed using git.
npm ERR! This is most likely not a problem with npm itself.
npm ERR! Please check if you have git installed and in your PATH.

npm ERR! Please include the following file with any support request:
npm ERR!     /npm-debug.log
[root@27bc17e95a98 /]# exit

Possible solution could be yarn which installs samlp properly, but because we are not using yarn it would make too much changes to our scripts. (large project)

Solution in samlp would be that in package.jsonfile you would directly point to .tar.gz file in xmldom dependency to fix this or publish your xmldom in to npm registry.

@ziluvatar could you verify this and perhaps fix package.json in samlp side?

Here is PR on this #87

Is there any progress on this? This is a huge issue when there is no git present on the system.

Can this please be fixed or #87 looked at and merged. Much of the corporate world is stuck behind firewalls and can't access github directly. We just want xmldom resolved from npm if possible.