auth0/node-samlp

Missing saml: prefix on Issuer and NameID tags in LogoutRequest

RutledgePaulV opened this issue · 1 comments

RutledgePaulV commented

Description

LogoutRequest xml contains <Issuer> and <NameID> tags instead of <saml:Issuer> and <saml:NameID> tags. This is inconsistent with other parts of this library and is incompatible with validation in some libraries like https://github.com/onelogin/java-saml.

Reproduction

Create a LogoutRequest xml, notice that the tags are <Issuer> and <NameID>.

Environment

Please provide the following:

  • Version of this library used: 3.4.1
RutledgePaulV commented

Actually I just had a misunderstanding of how xml namespaces work, the existing code technically is saying the same thing by setting namespace attributes on these two elements. The library I'm using just doesn't query for tags appropriately considering a different alias or an inline namespace may have been used.

If these are more common aliases it may be a worthwhile change still, but I no longer consider it to be a defect.