checkversion can return incorrect results on future versions
kalimag opened this issue · 0 comments
kalimag commented
The checkversion
method returns false
if any component of the current version is lower than the required version. That means 2.7.0
is considered lower than 2.6.1
, because 0 < 1
.
Currently the only effect is that the INCOMPATIBLE_BIZHAWK_VERSION
check does not warn about 2.7 incompatibility and a confusing/misleading warning about upgrading to MIN_BIZHAWK_VERSION
is shown instead.
bizhawk-shuffler-2/shuffler.lua
Lines 346 to 365 in 7545ddd
Environment:
- Bizhawk Version: 2.7