autopkg/recipes

Transmit5 Download recipe seems to pick the Intel version and not the Universal version.

Closed this issue · 5 comments

precursorca commented

Describe the problem
Transmit5 Download recipe seems to pick the Intel version and not the Universal version.

The download link at the web page pulls the Universal version:
https://panic.com/download/transmit/Transmit-5-Latest.zip

homebysix commented

For me, the Transmit5.download recipe pulls the Universal version:

% autopkg run -vv Transmit5.download                                                  
Processing Transmit5.download...
WARNING: Transmit5.download is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
SparkleUpdateInfoProvider
{'Input': {'appcast_query_pairs': {'appName': 'Transmit',
                                   'appVersion': '45656'},
           'appcast_request_headers': {'User-Agent': 'Transmit/5.0 '
                                                     'Sparkle/1.14.0'},
           'appcast_url': 'https://www.panic.com/updates/update.php'}}
SparkleUpdateInfoProvider: Version retrieved from appcast: 364373
SparkleUpdateInfoProvider: User-facing version retrieved from appcast: 5.8.4
SparkleUpdateInfoProvider: Found URL https://panic.com/download/transmit/Transmit%205.8.4.zip
{'Output': {'url': 'https://panic.com/download/transmit/Transmit%205.8.4.zip',
            'version': '5.8.4'}}
URLDownloader
{'Input': {'url': 'https://panic.com/download/transmit/Transmit%205.8.4.zip'}}
URLDownloader: No value supplied for prefetch_filename, setting default value of: False
URLDownloader: No value supplied for CHECK_FILESIZE_ONLY, setting default value of: False
URLDownloader: Storing new Last-Modified header: Thu, 10 Feb 2022 18:20:32 GMT
URLDownloader: Downloaded ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/downloads/Transmit%205.8.4.zip
{'Output': {'download_changed': True,
            'last_modified': 'Thu, 10 Feb 2022 18:20:32 GMT',
            'pathname': '~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/downloads/Transmit%205.8.4.zip',
            'url_downloader_summary_result': {'data': {'download_path': '~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/downloads/Transmit%205.8.4.zip'},
                                              'summary_text': 'The following '
                                                              'new items were '
                                                              'downloaded:'}}}
EndOfCheckPhase
{'Input': {}}
{'Output': {}}
Unarchiver
{'Input': {'archive_path': '~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/downloads/Transmit%205.8.4.zip',
           'destination_path': '~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/Transmit5',
           'purge_destination': True}}
Unarchiver: No value supplied for USE_PYTHON_NATIVE_EXTRACTOR, setting default value of: False
Unarchiver: Guessed archive format 'zip' from filename Transmit%205.8.4.zip
Unarchiver: Unarchived ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/downloads/Transmit%205.8.4.zip to ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/Transmit5
{'Output': {}}
CodeSignatureVerifier
{'Input': {'input_path': '~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/Transmit5/Transmit.app',
           'requirement': 'anchor apple generic and identifier '
                          '"com.panic.Transmit" and (certificate '
                          'leaf[field.1.2.840.113635.100.6.1.9] /* exists */ '
                          'or certificate 1[field.1.2.840.113635.100.6.2.6] /* '
                          'exists */ and certificate '
                          'leaf[field.1.2.840.113635.100.6.1.13] /* exists */ '
                          'and certificate leaf[subject.OU] = VE8FC488U5)'}}
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/Transmit5/Transmit.app: valid on disk
CodeSignatureVerifier: ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/Transmit5/Transmit.app: satisfies its Designated Requirement
CodeSignatureVerifier: ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/Transmit5/Transmit.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
{'Output': {}}
Receipt written to ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/receipts/Transmit5-receipt-20220313-141217.plist

The following new items were downloaded:
    Download Path                                                                                              
    -------------                                                                                              
    ~/Library/AutoPkg/Cache/com.github.autopkg.download.transmit5/downloads/Transmit%205.8.4.zip

Screen Shot 2022-03-13 at 2 12 37 PM

precursorca commented
homebysix commented

Shouldn't be — I ran again on an Intel Mac and got the same result.

The appVersion we're sending (45656) appears to be changed to 364373, based on the requests made to the Sparkle feed. I've committed the change here, but upon review I don't think it makes any difference in the resulting download.

Could you clear your cache, do a fresh run, and show the Apparency preview of the resulting app?

precursorca commented
homebysix commented

Excellent!