avast/retry-go

Custom retry function?

chmorgan opened this issue · 4 comments

chmorgan commented

I'd like to implement a custom retry function, one that will cap the delay time at some value vs. having it increase forever, as I'm currently trying to retry forever in a particular service. It doesn't look like that is possible as it would require being able to create a function that takes a parameter of type retry.config.

Is this not in the current model? I'm new to this package so I could easily be missing something.

JaSei commented

Hi, I think it is possible

you can define own DelayType (https://github.com/avast/retry-go/blob/master/options.go#L14)

retry.Do(
  func() error {//retryable function},
  retry.DelayType(func(n uint, config *config) time.Duration {
    //my custom delay function
  })
chmorgan commented

@JaSei you'd think so! This produces an 'undefined: config' error. Changing this to:

retry.Do(
  func() error {//retryable function},
  retry.DelayType(func(n uint, retry.config *config) time.Duration {
    //my custom delay function
  })

produces a 'cannot refer to unexpected name retry.config' error.

chmorgan commented

It may be that it is intentional not to expose the config struct, for encapsulation etc, but because its the parameter passed into these handlers it means it isn't possible to define new implementations. Maybe a dev could weigh in on possible approaches? It would seem reasonably ok to expose config to enable these functions to be customized but again I could be missing something and it does expand the public set of types from the package.

JaSei commented

please look at #16 - it should be solve the problem

  • 👍1