Extend useEffect to render the image in case it changes
Closed this issue · 3 comments
Hi,
Great improvements on the package, thanks for taking the time to share it with us.
I have a suggestion though in src/index.js line 50 to extend the useEffect
for changes to src
prop. E.g useEffect(() => // magic here),[src]);
;
I'm not quite sure if my assumption is right but I have a case of an image upload that fails to re-render because this effect works only when component is mounted.
Should you have further questions, please let me know.
Ciprian
Hi @ciprian-iacob , can you open a pull request with this change?
Great suggestion.
Hi @avishayil, we use your package and are very happy with it, thanks for your work.
There is this bug that can be closed by #72 , would you have the time to review and merge it?
Thanks,