avl/savefile

No impl (for WithSchema, etc) on char!

ctrlcctrlv opened this issue · 6 comments

ctrlcctrlv commented

I will PR.

avl commented

Oops, I guess I never thought about char! Ofcourse it should have av implementation. You are welcome to contribute a PR, but otherwise I'll fix this.

Thanks for reporting!

avl commented

Solved in commit be8474e , version 0.12 has been published to crates.io.

ctrlcctrlv commented

Thanks a lot :-) Sorry I didn't finish my patch, I was trying too hard to make it three bytes because technically that's all that's needed, haha.

ctrlcctrlv commented

(So I was trying to figure out how to avoid an unsafe cast and then decided to think about it later.)

avl commented

Oh, you're right! That's clever!

That would, however, mean that it couldn't implement the Savefile ReprC-trait, which would mean structs containing 'char' couldn't be serialized by just raw binary copy.

Would it have been better for your usecase to have char serialize to 3 bytes?

  • ❤️1
ctrlcctrlv commented

No, it wouldn't have made any difference at all except minor filesize decrease and bragging rights 😂

  • 👍1