avmnu-sng/rspec-tracer

Time formatter is broken

avmnu-sng opened this issue · 0 comments

@avmnu-sng I had to fix one of your changes in 0.6.0 because you had the following code in the wrong order

seconds, remainder = seconds.divmod(count) # remainder is a Number
remainder = format_duration(remainder) # remainder becomes a String

next if remainder.zero? # String does not have a zero? method

which should actually be

seconds, remainder = seconds.divmod(count)
next if remainder.zero?

remainder = format_duration(remainder)

Originally posted by @jwoodrow in #22 (comment)