avoidwork/filesize.js

standard='iec' is not default anymore

zerkms opened this issue · 2 comments

zerkms commented

The check is defined as:

standard = base === 2 ? descriptor.standard || "iec" : "jedec";

Which reads - if only base equals 2 - take the descriptor.standard. But base default value is 10.

Hence

filesize(265318, { standard: 'iec' });

would output "265.32 kB"

So it means:

  1. The readme is not entirely correct in its "(string) Standard unit of measure, can be iec or jedec, default is iec; can be overruled by base"
  2. standard option does nothing if base is not specified
avoidwork commented

yup, this is what people wanted for the last major release. i believe it was a mistake.

avoidwork commented

originally fixed with bb72429 and then undone with afd78c2 which i have no idea atm; however i completely agree what it's configured to do right now is inane.

  • 🎉1