Question: Support localize converting ?

Question

Question: Support localize converting ?

ahnpnl opened this issue 8 years ago · 5 comments

Hi,

I checked the document of filesize.js about converting to localized number but I couldn't find any options. Does filesize.js support converting to localized number ? For example in UK they use dot as decimal separator while some other countries they use comma

Answer 1 · 2018-02-02T10:48:14.000Z

Hi,

At this time it does not. If I were to add that, it would probably just be specifying a delimiter (default would be ""). How does that sound?

Answer 2 · 2018-02-02T10:49:37.000Z

Follow up question, if your formatting with a period, how do you know what's the decimal place?

Answer 3 · 2018-02-03T17:05:32.000Z

Hi,
I think providing an option to specify the delimiter sounds good. What I have in mind is after your library finishes the part of calculating the number, taking the option delimiter which the user passes in and use it to replace your comma. What do you think ? I don't know if the calculation needs to take into account of thousand separator as well or not

Answer 4 · 2018-02-03T17:15:45.000Z

oic, i misunderstood; shouldn't be a problem landing this.

Answer 5 · 2018-02-03T17:19:24.000Z

Perhaps providing an optional thousand separator input and also an optional decimal separator input looks better for me :) We don't know who wants to have thousand separator in their codes even though I don't see that case that often