skip installing apt-fast on cache hit

Question

skip installing apt-fast on cache hit

daaku opened this issue 2 years ago · 4 comments

Would it be possible to skip installing apt-fast if there is a cache hit? Maybe the installation can be moved to right before it's use in install_and_cache_pkgs?

Answer 1 · 2022-11-02T16:11:16.000Z

Sure that should be easy to do. The download of the tool should be fast. Are you seeing a slowdown or just from looking at the code?

Answer 2 · 2022-11-03T05:20:43.000Z

I only measured it locally and it seemed like an unnecessary slowdown for the cache hit case since it isn't used in that flow.

Answer 3 · 2022-11-03T13:56:11.000Z

I agree, it can be moved. Out of curiosity, what kind of latency were you seeing?

Answer 4 · 2022-11-03T14:04:26.000Z

I was seeing 1.2s locally from my laptop to curl the apt-fast installer CLI.