Don't override/monkey patch `String` class
n-rodriguez opened this issue · 3 comments
n-rodriguez commented
This is pretty unexpected : https://github.com/awesome-print/awesome_print/blob/master/lib/awesome_print/core_ext/string.rb
Defining those methods here https://github.com/awesome-print/awesome_print/blob/master/lib/awesome_print/colorize.rb with a string argument would be cleaner.
zw963 commented
Yes, i notice, ap auto require awesome_print/core_ext/string.rb
if make String#instance_methods more confusing ...
zw963 commented
Maybe we should add a config option to permit disable it.
n-rodriguez commented
Maybe we should add a config option to permit disable it.
or implement it properly : #421