Footer covering search button
ree17017 opened this issue · 7 comments
Describe the bug
When doing a Station to Station or Region to Region search the footer covers the search button
To Reproduce
Steps to reproduce the behavior:
- Go to https://evetrade.space/?trade=s2s or https://evetrade.space/?trade=r2r
- Try to click on search
Expected behavior
Be able to click on the search button
Screenshots
Desktop (please complete the following information):
- OS: Windows
- Browser Brave
- Version 1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)
@ree17017 Thanks for bringing this to my attention. Unfortunately, I will not be able to fix this as I am completely overhauling the UI. I am hoping to have the deployment complete by the end of the month which should address this bug. In the meantime, it looks like you are using Brave (which I do not test against), can you try another browser in the meantime?
You can track the progress here: https://feature-7-0-api-overhaul--evetrade.netlify.app/
Thanks, I will wait until the overhaul is done.
Side note: I tested this in chrome and I see the same issue.
@ree17017 Very interesting. Tried across my 3 computers (different resolutions) and I cannot replicate.
Can you provide me what resolution you are using? I'll see if I can replicate on my machine to ensure it doesn't happen with the overhaul.
Display Resolution: 1920 X 1080
Page Zoom is 100%
You have a position of absolute on your footer. Change it to relative and that fixed it.
I could create a PR if you would like.
@ree17017 good catch. I haven't updated the css in two years. I'll create a hot fix tomorrow and resolve this. I always assumed it was relative based on how the UI looks on my end. It's been a while. Apologies. :)
@ree17017 Created a quick bugfix. Can you review this preview build and see if it resolves it from your perspective?
Just making sure since I cannot replicate locally on any machine.
Build: https://bugfix-footer-covering-search--evetrade.netlify.app/
Edit: Merging into dev and then master. Just let me know if the problem persists with the new style changes.
Tested and looks great! Thank you for fixing this so quickly! ❤️