README: masking of account ID is unclear
cloudshiftchris opened this issue · 2 comments
Describe the issue
In the README it states:
By default, your account ID will not be masked in workflow logs. This was changed from being masked by default in the previous version. AWS does consider account IDs as sensitive information, so this change reflects that stance. You can revert to the old default and mask your account ID in workflow logs by setting the mask-aws-account-id input to true.
...which has these contradictory statementst:
- account ID will NOT be masked;
- AWS DOES consider account IDs as sensitive information
Further in the README it states:
Your account ID is not masked by default in workflow logs since it's not considered sensitive information.
From the default behaviour presumably AWS does NOT consider account IDs as sensitive; the initial statement is incorrect.
You're correct. This was simply a typo that we missed during review, fixed with #799. Thanks for reporting!
** Note **
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.