aws-beam/aws-elixir

Potential breaking changes not documented on CHANGELOG.md

kw7oe opened this issue ยท 2 comments

kw7oe commented

Hi all, just wanted to raise up an issue where a potential breaking changes is not documented in CHANGELOG.md.

In short, we found out that the error response of v0.5.0 is different compared to v.0.9.2 when attempting to update our dependencies:

# v0.5.0
{:error, {exception, message}}

# v0.9.2
{:error, {:unexpected_response, response}}

After some deep dive, here's the file changes related:

It seems like the changes happen after v0.7.0 according to this commit.

Am I right in regards of this as a breaking changes? If so, would it be good for us to update the CHANGELOG.md to document the breaking changes?

Happy to send a PR in and thanks for the amazing work as well ๐ŸŽ‰

@kw7oe my bad ๐Ÿ˜…
Yeah, It makes sense to document this. Please go ahead with the PR ๐Ÿ‘
And thank you! ๐Ÿ’œ

kw7oe commented

All good @philss ๐Ÿ‘๐Ÿป, no worry! It's just an oversight. Things happen, so nothing to sorry about.

I'll close this first since the PR is in!

Once again, thanks for all the work on this library ๐Ÿ’ฏ