normalize_query won't work for s3 select
joshuataylor opened this issue ยท 3 comments
joshuataylor commented
select_object_content builds a query string like this:
select&select-type=2
normalize_query then expects URLs to have = in them, but this doesn't.
This causes the API not to work. So the function needs to be updated to support this edgecase.
I'll take a look at creating a PR for this ๐
philss commented
@joshuataylor good catch! Maybe changing https://github.com/aws-beam/aws-elixir/blob/master/lib/aws/signature.ex#L227 to accept it is enough? I imagine swapping the comma by a cons |
in the sort function args fixes the problem. WDYT? A PR is welcome!
jonatanklosko commented
I believe this should be fixed by #86.
philss commented
Yeah, I believe this is fixed. Thanks, @jonatanklosko! ๐
@joshuataylor please feel free to re-open if you find any issues.