aws-neuron/neuronx-nemo-megatron

Typo in nemo.collections.nlp.parts.serialization.py

Closed this issue · 1 comments

Hi,

In serialization.py, the save method will use SimpleSaver (when
save_xser is true):

class SimpleSaver:

    def __init__(self):
        pass

    def add_save_task(self, data, path):
        torch.save(data, path)

However, in line 105, it tries to instantiate SimplerSaver (instead of SimpleSaver):

  if saver is None:
      saver = SimplerSaver()

This is causing a crash:

    saver = SimplerSaver()
NameError: name 'SimplerSaver' is not defined

Addressed in PR #26