cleanup_response() - code quality issue and probable bug
ilyash-b opened this issue · 1 comments
ilyash-b commented
for k in ["Complete", "Poll", "permission", "rule"]
is meaningless because k
is not used inside the for.
if k in response_data.keys():
together with del response_data[k]
should delete all the keys.
Overall, the code doesn't seem to be intentional.
ilyash-b commented
My mistake, ignore. Could be improved with if k in response_data
I think.