aws-samples/aws-modern-application-workshop

AWS CLI ecr get-login throwing error Invalid choice

checker21 opened this issue · 1 comments

In the Step “C: Push the Docker Image to Amazon ECR” you have to execute the following command:
$(aws ecr get-login --no-include-email)

But this command is only working in AWS CLI 1.x. Since AWS CLI 2.x, the command get-login no longer exists and you will get invalid choice error message. The following command is doing the trick:

aws ecr get-login-password --region region | docker login --username AWS --password-stdin aws_account_id.dkr.ecr.region.amazonaws.com

It would be great seeing a hint in this tutorial. It would save the user a lot of research time.
Thanks.

Submitted a pull request for this, but here's a line to do it auto-magically:
aws ecr get-login-password --region $(aws configure get region) | docker login --username AWS --password-stdin $(aws sts get-caller-identity --qu ery Account --output text).dkr.ecr.$(aws configure get region).amazonaws.com