aws-samples/iam-identity-center-team

Deployment from none main branch

Closed this issue · 3 comments

mburket commented

Describe the bug
Currently, the TEAM app can only be deployed from the main branch. We would like to be able to deploy it from none main branch for testing. Also, we want to be able to deploy to an AWS account which is neither a management account nor a delegated admin account for testing purpose. The cloud trail lake resources creation needs to be disabled for a none delegated account, otherwise the deployment will fail. The ability to deploy to a different account and from a different branch allows us to set up a testing instance of the application.

To Reproduce

  1. Create a new branch, deploy the app. It will fail during the cloudformation setup.
  2. Deploy the app to a none delegated account, it will fail during the cloudformation setup.

Expected behavior

  1. The TEAM app can be deployed from any branch.
  2. The TEAM app can be deployed to any account.
github-actions commented

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed.

mburket commented

Rebased my PR from main.

github-actions commented

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed.