aws-solutions/qnabot-on-aws

Shell and other commands not working in Ubuntu linux

bchunduri opened this issue · 4 comments

bchunduri commented

Team,

We use Ubuntu (Ubuntu 22.04.2 LTS) linux machine to bootstrap the QnA bot solutions and render the stack templates to suit our environment.

The bootstrap fails at quite a few places as described below:

  1. The first line of the main Makefile contains shell command which do not exists in Ubuntu and it is more like a MacOS command shell. Please fix this so can support for any OS (MacOS, Windows, Linux) >> As an alternative we have amended the logic with a for loop.

  2. The pushd & popd commands in the file ml_model/embedding/package-model.sh fails though exists in the Linux, the reason is could be the sh shell it is using in the ml_model/embedding/Makefile that was incorrect >> Amending this with zsh worked where pushd and popd found in zsh or ksh shell.

Appreciate your review and fix on the above.

dougtoppin commented

@bchunduri Thanks for your report. We will evaluate it and get back to you.

abhirpat commented

related PR #736

fhoueto-amz commented

the file ml_model/embedding/package-model.sh has been deprecated.

fhoueto-amz commented

Unfortunately, we support only Amazon Linux for now and have not seen enough uptake to support Ubuntu. I will close this ticket. You can submit an enhancement request if you for consideration in the roadmap if needed.