aws/amazon-vpc-cni-k8s

No version number reported in CloudTrail history.

guessi opened this issue · 3 comments

guessi commented

What happened:

While troubleshooting VPC CNI related event, it is better to have version number included.

But the fact is that there's no version number reported in CloudTrail history, hard to tell which version was applied.

Version defined HERE and HERE seems like not defined, but I'm not sure how to fix it correctly, so I create the bug report here.

image

Attach logs

n/a

What you expected to happen:

Version info should be included in CloudTrail events.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

It's a long lasting bug, version is not that important.

jdn5126 commented

This is a good call out @guessi , thank you for the report! Yeah, that version variable should be set based on the current VPC CNI version. We should do the same for our Kubernetes client userAgent: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/k8sapi/k8sutils.go#L174

I marked this as a good first issue, and will try to find someone to work on this.