aws/amazon-vpc-cni-k8s

Refactor iptable mock

jchen6585 opened this issue · 2 comments

What would you like to be added:
Issue to keep track of refactoring iptable mock

Why is this needed:
Currently, our mock has some empty functions and only map the chain to rules that start with -A. We specifically should add chain creation rules to the map as well -N. This leaves some gaps in our test coverage such as testing https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/networkutils/network.go#L379

Closing as fixed by #2721

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.