aws/aws-app-mesh-examples

Samples using deprecated APPMESH_VIRTUAL_NODE_NAME

russau opened this issue · 1 comments

russau commented

I'm working through the colorapp example, and I see the ECS tasks created use APPMESH_VIRTUAL_NODE_NAME

There's a warning in the docs that this setting has been deprecated in envoy.

The environment variables APPMESH_VIRTUAL_NODE_NAME and APPMESH_RESOURCE_NAME are no longer supported in Envoy version 1.15.0 or later. However, they're still supported for existing meshes. Instead of using these variables with Envoy version 1.15.0 or later, use APPMESH_RESOURCE_ARN for all App Mesh endpoints.

I'm running v1.21.0.0-prod and everything works fine. Should the example be updated to use APPMESH_RESOURCE_ARN?

neiljohari commented

I wish I saw this earlier. This definitely needs to be updated, I used latest image while debugging other issues and only made the situation take more hours to debug because of this.