aws/aws-lambda-dotnet

POST parameters with unicode symbols are not parsed correctly

ivancoso opened this issue · 4 comments

ivancoso commented

Describe the bug

We recently updated the version of Amazon.Lambda.Annotations nuget package from 1.0.0 to 1.5.0 and experiencing the following issue: when we call a POST request with unicode symbols in it's body, there is wrong parsing of unicode symbols for parameters marked with [FromBody] attribute (those symbols are parsed as question marks).

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

Unicode symbols parsed correctly for POST parameters, like it was in version 1.0.0

Current Behavior

Assuming the POST body is {"title": "にちは世界"}, we expect that dto.Title property would be set to 'にちは世界' but instead it's set to '?????' :
// POST body : {"title": "にちは世界"}
[LambdaFunction()]
[HttpApi(LambdaHttpMethod.Post, "/")]
public async Task Create(APIGatewayHttpApiV2ProxyRequest request, [FromBody] CreateDto dto)
{
_logger.LogInformation(dto.Title); // output: '?????'
_logger.LogInformation(request.Body); // output: '{"title": "にちは世界"}'
}

Reproduction Steps

// POST body : {"title": "にちは世界"}
[LambdaFunction()]
[HttpApi(LambdaHttpMethod.Post, "/")]
public async Task Create(APIGatewayHttpApiV2ProxyRequest request, [FromBody] CreateDto dto)
{
_logger.LogInformation(dto.Title); // output: '?????'
_logger.LogInformation(request.Body); // output: '{"title": "にちは世界"}'
}

Possible Solution

revert to versin 1.0.0 or investigate and probably update the lib code to perform UTF-8 encoding instead of ASCII

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

<PackageReference Include="Amazon.Lambda.APIGatewayEvents" Version="2.7.1" />
<PackageReference Include="Amazon.Lambda.Logging.AspNetCore" Version="3.1.0" />
<PackageReference Include="Amazon.Lambda.Serialization.SystemTextJson" Version="2.4.3" />
<PackageReference Include="Amazon.Lambda.Annotations" Version="1.0.0" />
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.400.12" />
<PackageReference Include="AWSSDK.Extensions.NETCore.Setup" Version="3.7.301" />
<PackageReference Include="AWSSDK.SimpleNotificationService" Version="3.7.400.12" />
<PackageReference Include="AWSXRayRecorder.Handlers.AwsSdk" Version="2.13.0" />

Targeted .NET Platform

.NET 6

Operating System and version

AWS lambda, .net 6 setup

normj commented

@ivancoso I have reproduced the issue and confirmed this is a regression. We will work on getting a fix out quickly.

ashishdhingra commented

@ivancoso I have reproduced the issue and confirmed this is a regression. We will work on getting a fix out quickly.

@normj Thanks for quick reproduction.

normj commented

@ivancoso version 1.5.2 of Amazon.Lambda.Annotations has been released with the fix. Thanks for reporting the issue.

  • 👍1
github-actions commented

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.