aws/aws-lambda-dotnet

LambdaStartupAttribute summary does not match documentation

Closed this issue · 2 comments

474D commented

Describe the issue

In the latest documentation ref: https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.Annotations/README.md

It is stated that recommended way of using LambaStartupAttribute is to use ConfigureHostBuilder
Example startup class using the recommended ConfigureHostBuilder

And for legacy cases to use ConfigureServices
For legacy support, you can still use the ConfigureServices method

In the LambdaStartupAttribute summary only the legacy way is described, ref:

/// <summary>
/// Indicates that the class will be used for registering services that 
/// can be injected into Lambda functions.
/// </summary>
/// <remarks>
/// The class should implement a ConfigureServices method that 
/// adds one or more services to an IServiceCollection.
/// </remarks>

I have attached #2064 PR with the suggested fix.

Links

https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.Annotations/LambdaStartupAttribute.cs

Lines 5-12.

474D commented

Completed with #2064

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.