aws/aws-node-termination-handler

Missing Helm chart for `1.22.0`

stevehipwell opened this issue · 7 comments

stevehipwell commented

Describe the bug
Due to the (Windows) build failing the Helm chart hasn't been published.

The Windows build failing is due to it attempting to run a bash script without an interpreter. The call to upload-resources-to-github could be temporarily removed from the makefile for Windows to stop this blocking each release. There are a number of potential options for resolving this, I've listed a couple of them out here.

  • Write upload-resources-to-github.ps1 as a PowerShell version of upload-resources-to-github to be used for Windows
  • Install WSL on the runner and try to use the existing script
  • Output the binary from the Windows job and upload in the next job
  • Create the binaries with GoReleaser in a separate job to the OCI image creation to create the release and upload the binaries

Steps to reproduce
helm pull oci://public.ecr.aws/aws-ec2/helm/aws-node-termination-handler --version 0.24.0

Expected outcome
I'd expect the Helm chart to have been published.

Application Logs
n/a

Environment

  • NTH App Version:
  • NTH Mode (IMDS/Queue processor):
  • OS/Arch:
  • Kubernetes version:
  • Installation method:
LikithaVemulapalli commented

Hello @stevehipwell, we are aware of this issue, we will fix this as soon as possible, thank you

stevehipwell commented

@LikithaVemulapalli by reverting the v1.22.0 release you've broken our clusters where we manually set the image tag in the Helm chart, this release was an urgent bug fix. Release artifacts should be immutable, the v1.22.0 release should have been completed manually so as to not break any usage.

Do you need any help getting the automation working so we can get access to v1.22.0.

  • 👀1
LikithaVemulapalli commented

Hello @stevehipwell, we apologize for the inconvenience that you are facing, we wanted to fix the release automation, we did manually upload helm charts and windows binaries for the last release. We do not want to manually do it every single time, so reverted the release. We tried installed the wsl in the runner that didn't help, so currently working on the alternate options. For now, as this release is breaking your clusters, will upload manually and work on the fix after release. Thank you.

  • 👍1
stevehipwell commented

@LikithaVemulapalli why not disable the Windows binary upload for now (skip the script in make), that way you only have to do that one step manually (and if it's missed it's unlikely to be an issue).

LikithaVemulapalli commented

yes @stevehipwell , I'm planning to modify the release-windows in make file and remove upload-assets-to-windows for now, and add it manually after the release, I wanted to fix this sooner so had the setup ready in my fork to test release, but since the release is urgent, I will do the release, we will have the helm chart uploaded today, thank you.

  • 👍1
stevehipwell commented

Thanks @LikithaVemulapalli, this is working correctly now.

  • 🎉1