Include EventID in metrics

Question

Include EventID in metrics

cmotta2016 opened this issue 2 years ago · 7 comments

cmotta2016 commented 2 years ago

Describe the feature
We're running NTH to handler AZ Rebalance recommendation and Spot interruption notification. We need to build a Grafana dashboard to show only the number of instances terminated by Spot interruption. So if there is a label like event-id=spot-itn-event... we can filter the query by this label.

Is the feature request related to a problem?
When using Grafana/Prometheus we can't filter instances terminated by a specific event.

Describe alternatives you've considered
/

Answer 1 · 2022-07-16T17:03:54.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

Answer 2 · 2022-07-29T00:26:49.000Z

Thanks a lot @cmotta2016 and @snay2 for merging this change in.

Would it be possible to make a release for with this change?

I see that the image - https://gallery.ecr.aws/aws-ec2/aws-node-termination-handler, was updated couple of months ago?

Answer 3 · 2022-07-29T02:07:18.000Z

@mohitreddy1996 You're correct, our most recent release was 2 months ago in May, v1.16.5. We're planning to cut another release early next week once we get the fix for #654 merged. I'll update this issue once that happens.

Answer 4 · 2022-07-29T02:22:22.000Z

Awesome! Thanks a bunch :)

Answer 5 · 2022-08-15T04:18:09.000Z

Hi @snay2 , quickly wanted to check on the progress of cutting a new release. Any ETAs? Thanks in advance :)

Answer 6 · 2022-08-15T23:17:57.000Z

Thanks for checking in! The fix is nearly ready: #669, with a couple last-minute adjustments to make. I expect we'll release in the next day or two.

Answer 7 · 2022-08-18T16:25:42.000Z

This has finally been released! NTH app version v1.17.0. Helm chart version v0.19.0.