aws/aws-node-termination-handler

helm: add envFrom templating option

cesarmira opened this issue · 3 comments

cesarmira commented

Describe the feature
I would like to be able to configure the DaemonSet envFrom values from the values.yaml

Is the feature request related to a problem?
No, as right now we can't configure it at all.

Describe alternatives you've considered
At the moment, we are rendering the chart, updating the manifest and applying it manually. We believe it would be nice to be able to do it everything from the chart.

snay2 commented

Thanks for the suggestion! We'd be happy to accept a pull request with a fix for this issue.

Along with that, we'll help write an end-to-end test that verifies that the environment variables successfully appear in the pod after launch.

github-actions commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

github-actions commented

This issue was closed because it has become stale with no activity.