aws/aws-node-termination-handler

Node Termination Handler only logs to stderr

vbyrd opened this issue · 1 comments

vbyrd commented

Describe the bug
NTH only logs to stderr

See this line of code for the culprit:

aws-node-termination-handler/cmd/node-termination-handler.go

Line 59 in 70eab88

log.Logger = log.Output(zerolog.ConsoleWriter{Out: os.Stderr, TimeFormat: timeFormat, NoColor: true})

Steps to reproduce
View log output of the NTH with stderr redirector to /dev/null

Expected outcome
NTH logs to stdout for normal events and stderr for actual error events.

Application Logs
aws-node-termination-handler-logs

Environment

  • NTH App Version: v1.16.5
  • NTH Mode (IMDS/Queue processor): QP
  • OS/Arch: linux
  • Kubernetes version: 1.22
  • Installation method: Helm
snay2 commented

This has been released in v1.17.1, chart version 0.19.1