aws/aws-node-termination-handler

imds asg target lifecycle hook

pete911 opened this issue · 5 comments

Describe the feature
Target lifecycle state is available through instance metadata since March 2022 - https://docs.aws.amazon.com/autoscaling/ec2/userguide/retrieving-target-lifecycle-state-through-imds.html It would be nice to enable this on aws-node-termination-handler when deployed in imds mode.

Is the feature request related to a problem?
Even though ASG Termination lifecycle hook is available in Queue processor mode, for some cases this adds additional infrastructure complexity (SQS, private link to SQS, permissions etc.), it would be nice to add this in IMDS mode as well, since it is available.

Initial pull request (tested in EKS cluster as well) is here #825

@cjerad is this something you would like to merge? I removed staled label from the PR twice, but it has now been closed.

Hi @jillmon, @cjerad any news on this?