New `condition-node` option
rrangith opened this issue · 3 comments
Describe the feature
Looking at the config options, I see there is a taint-node option, which gets applied when an interruption event occurs.
The feature request is to have a similar condition-node
option that if true, would add a condition to the node's status.
For example, for a spot interruption, the node gets the taint aws-node-termination-handler/spot-itn
. The condition could be of the form:
type: "aws-node-termination-handler/spot-itn"
status: "True"
reason: "aws-node-termination-handler"
message: "aws-node-termination-handler detected spot interruption"
lastHeartBeatTime: time.now()
lastTransitionTime: time.now()
This is useful for some of our tooling which reacts to node conditions. There is also an upstream project which reacts to the nodes getting conditions https://github.com/planetlabs/draino
Is the feature request related to a problem?
The taint is useful, but we would also prefer a condition
Describe alternatives you've considered
We could stick to using the taint, but I don't see harm in giving an option to add a condition to the node too. By default it will be false
, so no harm in adding it
If this proposal sounds good, I can put up a PR to implement this
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.
This issue was closed because it has become stale with no activity.