aws/aws-pdk

[BUG] (monorepo) upgrade-deps using outdated syncpack (error)

dkershner6 opened this issue · 1 comments

Describe the bug

Your syncpack config file contains values deprecated in https://github.com/JamieMason/syncpack/releases/tag/9.0.0
  Dependency Types: dev,overrides,peer,pnpmOverrides,prod,resolutions
  Docs: https://jamiemason.github.io/syncpack/config/dependency-types

Expected Behavior

To upgrade the monorepo's dependencies.

Current Behavior

Throws error in description.

Reproduction Steps

This should be happening in all new PDK monorepos, it would seem, but here is the syncpack file:

{
  "dependencyTypes": [],
  "dev": true,
  "filter": ".",
  "indent": "  ",
  "overrides": true,
  "peer": true,
  "pnpmOverrides": true,
  "prod": true,
  "resolutions": true,
  "workspace": true,
  "semverGroups": [],
  "semverRange": "",
  "sortAz": [
    "contributors",
    "dependencies",
    "devDependencies",
    "keywords",
    "peerDependencies",
    "resolutions",
    "scripts"
  ],
  "sortFirst": [
    "name",
    "description",
    "version",
    "author"
  ],
  "source": [],
  "versionGroups": [],
  "//": "~~ Generated by projen. To modify, edit .projenrc.ts and run \"pnpm exec projen\"."
}

"syncpack": "^12.3.0",

Possible Solution

Workaround: Downgrade syncpack 4 major versions to ^8. You must use addDevDeps or the PDK overwrites your version.

Additional Information/Context

No response

PDK version used

0.22.48

What languages are you seeing this issue on?

Typescript

Environment details (OS name and version, etc.)

Ubuntu 22.04

Hi @dkershner6.
Incase it's useful, this is the equivalent config with the breaking changes applied for v9+

{
-  "dependencyTypes": [],
+  "dependencyTypes": ["dev", "overrides", "peer", "pnpmOverrides", "prod", "resolutions", "local"],
-  "dev": true,
  "filter": ".",
  "indent": "  ",
-  "overrides": true,
-  "peer": true,
-  "pnpmOverrides": true,
-  "prod": true,
-  "resolutions": true,
-  "workspace": true,
-  "semverGroups": [],
-  "semverRange": "",
+  "semverGroups": [{
+    "dependencies": ["**"],
+    "dependencyTypes": ["**"],
+    "packages": ["**"],
+    "range": ""
+  }],
  "sortAz": [
    "contributors",
    "dependencies",
    "devDependencies",
    "keywords",
    "peerDependencies",
    "resolutions",
    "scripts"
  ],
  "sortFirst": [
    "name",
    "description",
    "version",
    "author"
  ],
  "source": [],
  "versionGroups": [],
  "//": "~~ Generated by projen. To modify, edit .projenrc.ts and run \"pnpm exec projen\"."
}